-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply ansi_up to "text" output #6
Comments
Thanks for suggesting this, Justin! I think that's a very reasonable proposal. I'll look into incorporating this while not degrading the rendering for other text output cells. |
is there an update on this issue ? |
@chandhana520 I haven't had the time to write or (especially) test code that would achieve this yet. But it does still seem worthwhile. |
How can i use nbpreview for my vue application |
Hello, just checking in on whether there has been any progress with this issue? |
Almond and others output ansi-formatted text as "text/plain"
ex. https://github.com/almond-sh/almond/blob/master/examples/plotly-scala.ipynb
GitHub filters this out (without highlighting), but nbpreview is currently not even doing the filtering. This results in garbled text:
I would recommend applying at least the filtering of ansi, possibly the highlighting as well. I made the following tweak locally:
nb.display.text=function(text){var el=makeElement("pre",["text-output"]);el.innerHTML=nb.highlighter(nb.ansi(joinText(text)),el);return el}
Resulting in:
Best
Justin
The text was updated successfully, but these errors were encountered: