Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexbox layout is not laying out properly in Firefox #1

Open
swetland opened this issue Jan 25, 2019 · 3 comments
Open

Flexbox layout is not laying out properly in Firefox #1

swetland opened this issue Jan 25, 2019 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@swetland
Copy link

  1. It would be nice if the info-box received focus when popped up, so keyboard scrolling acted on it rather than the (obscured) instruction list
  2. It would be useful to be able to link directly to an instruction (maybe by tacking #opcode on the end of the URL)
@jtgans
Copy link
Owner

jtgans commented Jan 26, 2019

Okay, give it a shot now. I made the description full frame and adjusted a whole bunch to make it work using anchors.

@swetland
Copy link
Author

It's looking good!

Two things:

  • after you pop up instruction info and then dismiss it the #opcode remains in the url such that if you reload the page or bookmark it or whatnot, you end up back on the instruction info
  • layout is a little weird (see attached) in Firefox on Ubuntu -- it almost manages to get all the instructions on one page tidily. looks similar on Chromium on Ubuntu

layout

@jtgans
Copy link
Owner

jtgans commented Feb 13, 2019

Yeah. I'm not exactly sure what is going on with that. It's like flexbox isn't reacting to the width properly.

@jtgans jtgans added bug Something isn't working help wanted Extra attention is needed labels Apr 23, 2021
@jtgans jtgans changed the title Minor QoL Feature Requests Flexbox layout is not laying out properly in Firefox Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants