Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support light and dark color themes #261

Open
jtmoon79 opened this issue Mar 23, 2024 · 0 comments
Open

support light and dark color themes #261

jtmoon79 opened this issue Mar 23, 2024 · 0 comments
Labels
enhancement New feature or request P1 important

Comments

@jtmoon79
Copy link
Owner

jtmoon79 commented Mar 23, 2024 •
edited
Loading

Summary

The built-in colors should support light theme consoles.

Current behavior

Colors are hardcoded for a dark background console (dark theme).

Suggested behavior

Support at least light and dark console backgrounds (themes).

Other

Is it possible to query the OS for the user-preferred color theme?
Or is there a known environment variable?

Is there a crate that can help with choosing colors, i.e. does some magic to determine the color context and choose the best palette of colors?
@jtmoon79 jtmoon79 added enhancement New feature or request P1 important labels Mar 23, 2024
jtmoon79 added a commit that referenced this issue Mar 23, 2024
@jtmoon79
printers.rs improve colors for dark background
cd52d9d 
relates to Issue #261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P1 important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtmoon79