Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] The wrong way to determine the port restricted NAT or restricted NAT #14

Open
hmgle opened this issue Apr 29, 2015 · 1 comment
Open

[Bug] The wrong way to determine the port restricted NAT or restricted NAT #14

hmgle opened this issue Apr 29, 2015 · 1 comment

Comments

@hmgle
Copy link

hmgle commented Apr 29, 2015

When we do Test3 to determine the client is behind a restricted or port restricted NAT, this line:

ret = stun_test(s, changedIP, port, source_ip, source_port, changePortRequest)

will request stun server sends a response from addr(changedIP:changedPort). As we have just send a request:

ret = stun_test(s, changedIP, changedPort, source_ip, source_port)

both RestricNAT and RestricPortNAT will receive the response. So we alway get typ = RestricNAT even if behind a port restricted NAT.
hmgle added a commit to hmgle/pystun that referenced this issue Apr 29, 2015
@hmgle
fix jtriley#14: in test3, the client should send Request from the las…
d7e7c2f 
…t used addr with changeport flag
@YF-Tung
Copy link

YF-Tung commented Nov 9, 2016

@hmgle is right.
@jtriley please fix this issue, please.
Out team was misled by this result for several days.

konradkonrad pushed a commit to konradkonrad/pystun that referenced this issue Apr 3, 2017
@hmgle @konradkonrad
fix jtriley#14: in test3, the client should send Request from the las…
7ca4fc2 
…t used addr with changeport flag
konradkonrad added a commit to konradkonrad/pystun that referenced this issue Apr 3, 2017
@konradkonrad
Merge pull request #1 from konradkonrad/fix_test3
5d0922a 
fix jtriley#14: in test3, the client should send Request from the last used …
konradkonrad pushed a commit to konradkonrad/pystun that referenced this issue Apr 18, 2017
@hmgle @konradkonrad
fix jtriley#14: in test3, the client should send Request from the las…
69f0b3f 
…t used addr with changeport flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hmgle @YF-Tung