Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add host_info to api for nodes #2208

Open
2 tasks
akelge opened this issue Oct 23, 2024 · 2 comments
Open
2 tasks

[Feature] Add host_info to api for nodes #2208

akelge opened this issue Oct 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@akelge
Copy link

akelge commented Oct 23, 2024

Use case

I am still developing a web UI for headscale and I would really love to add the OS, OS version and tailscale version to the node information.
This can be useful to debug issues and for statistical purposes.

Description

The nodes in the DB have a field called host_info that contains several interesting information, like OS, OS version, tailscale version, arch and even RTT to DERP nodes.
These info, though, are not returned by the REST API.
It would be useful to return them.

Contribution

  • I can write the design doc for this feature
  • I can contribute this feature

How can it be implemented?

Add host_info to the field returned when calling /node or /node/<node_id>

@akelge akelge added the enhancement New feature or request label Oct 23, 2024
@ArcticLampyrid
Copy link
Contributor

maybe #1205 #1938

@kradalby
Copy link
Collaborator

Yes, as @ArcticLampyrid points out, there has been a couple of attempts, it has been blocked by the "strictness" of gRPC which has not allowed us to do this in an ergonomic way without requiring sending the JSON as a escaped string making a terrible API.

I think there are some details in the linked PR/Issues. Happy for someone to work on it, but unless we figure out how to make it "nice" we wont merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants