Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate ConnectRPC over gRPC + webgateway #2305

Open
kradalby opened this issue Dec 17, 2024 · 2 comments
Open

Evaluate ConnectRPC over gRPC + webgateway #2305

kradalby opened this issue Dec 17, 2024 · 2 comments
Labels
help wanted Extra attention is needed needs investigation no-stale-bot question Further information is requested

Comments

@kradalby
Copy link
Collaborator

We currently use plain gRPC and grpc-gateway (for our http+json) api, it has worked fine, but also there are a couple of drawbacks, and it kind of feels a bit hacky.

One of the drawbacks is that some parts of gRPC is unsupported by grpc-gateway, and it does not support OpenAPI 3.0. oneof is for example not supported #2237.

ConnectRPC seem to be a rethinking of this, where the gRPC and the HTTP part is "equally" important. It might be better, it might be worse, they advertise with good client code generators so might be worth a look.

Initial thoughts:

  • Con: This will break current web UIs
  • Pro: they can use a generated client instead of handwriting API
  • Cant see any OpenAPI support, but if their code gen is good, then I dont think that matters
  • "If it aint broke, dont fix it"

I would value peoples views, particularly if you have experience using this.

@kradalby kradalby added help wanted Extra attention is needed question Further information is requested needs investigation no-stale-bot labels Dec 17, 2024
@perezd
Copy link

perezd commented Dec 19, 2024

RE: OpenAPI support, there's a fantastic plugin for this that supports Connect: https://github.com/sudorandom/protoc-gen-connect-openapi?tab=readme-ov-file

If you'd like to chat about the eval w/ the Connect team we're here in Slack: https://buf.build/b/slack

@majst01
Copy link
Contributor

majst01 commented Dec 20, 2024

As a long term user of the connectrpc stack since the 0.1 version, i really can say that this was the best improvement of the grpc ecosystem ever. Could only say good things about that. So go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs investigation no-stale-bot question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants