Merge pull request #299 from julia-vscode/sp/robust-subprocess-startup

fix: make subprocess startup more robust

Author: pfitzseb

src/SymbolServer.jl

@@ -230,11 +230,28 @@ function getstore(ssi::SymbolServerInstance, environment_path::AbstractString, p
     # 1.11 introduces the --compiled-modules=existing option, which should be much faster than no
     #   as of 2023-11-09, loading Pkg with --compiled-modules=no also changes something with the
     #   active project, which breaks the server.jl script
-    p = if ssi.julia_exe_version > v"1.11-"
-        open(pipeline(Cmd(`$(ssi.julia_exe_path) --code-coverage=$(use_code_coverage==0 ? "none" : "user") --startup-file=no --compiled-modules=existing --history-file=no --project=$environment_path $server_script $(ssi.store_path) $pipename`, env=env_to_use),  stderr=stderr), read=true, write=true)
-    else
-        open(pipeline(Cmd(`$(ssi.julia_exe_path) --code-coverage=$(use_code_coverage==0 ? "none" : "user") --startup-file=no --compiled-modules=no --history-file=no --project=$environment_path $server_script $(ssi.store_path) $pipename`, env=env_to_use),  stderr=stderr), read=true, write=true)
+    p = try
+        path = ssi.julia_exe_path
+        spath = split(path)
+        # is julia up spec
+        if length(spath) == 2 && occursin(r"^\+\d", spath[2])
+            path = spath
+        else
+            path = [path]
+        end
+        cmd = Cmd(path)
+        if ssi.julia_exe_version > v"1.11-"
+            open(pipeline(Cmd(`$(cmd) --code-coverage=$(use_code_coverage==0 ? "none" : "user") --startup-file=no --compiled-modules=existing --history-file=no --project=$environment_path $server_script $(ssi.store_path) $pipename`, env=env_to_use),  stderr=stderr), read=true, write=true)
+        else
+            open(pipeline(Cmd(`$(cmd) --code-coverage=$(use_code_coverage==0 ? "none" : "user") --startup-file=no --compiled-modules=no --history-file=no --project=$environment_path $server_script $(ssi.store_path) $pipename`, env=env_to_use),  stderr=stderr), read=true, write=true)
+        end
+    catch err
+        if stderr_for_client_process !== nothing
+            showerror(stderr_for_client_process, err)
+        end
+        return :failure, stderr_for_client_process
     end
+
     ssi.process = p
 
     yield()