Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling both imperial and metric measurements #1428

Open
ddbrain opened this issue Jul 31, 2024 · 1 comment
Open

Scaling both imperial and metric measurements #1428

ddbrain opened this issue Jul 31, 2024 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@ddbrain
Copy link

ddbrain commented Jul 31, 2024

Is your new feature related to a problem? Please describe.
Currently when using the scaling feature only the imperial measurement is scaled when a measurement includes both imperial and metric. such as "1 teaspoon (2 grams) salt" becomes "2 teaspoons (2 grams) salt"

Describe the solution you'd like
It would be nice if the scaling tool could recognize both the imperial and metric measurements and scale both. Making the above example at 2x scale converted to "2 teaspoons (4 grams) salt"

@ddbrain ddbrain added the feature New feature or request label Jul 31, 2024
@julianpoy
Copy link
Owner

Definitely could be added. The regex simply doesn't check for a second set of measurements in parenthesis after the originating measurement. Shouldn't be too hard, but does conflict with some of the improvements here: #1078. I'll take a look and see if I can add support there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants