Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move zipfile to peerDependencies #51

Open
xamgore opened this issue May 23, 2020 · 0 comments
Open

Move zipfile to peerDependencies #51

xamgore opened this issue May 23, 2020 · 0 comments

Comments

@xamgore
Copy link
Contributor

xamgore commented May 23, 2020 •
edited
Loading

npm install also installs optional dependencies, zipfile in case of epub package. I suggest moving it to peerDependencies.

At the moment node-gyp is called to compile zipfile on macOS Catalina, Node 13/14, fails, and prints a huge error stack in the log. Every time I call npm install. It can be fixed with npm set optional false, but...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xamgore