You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
thank you very much for providing this code. I found it very useful.
I just wondered, whether the computation of beta_k in the cg algorithm in the update step of CGD in the second experiment contains a typo:
I think the line denom += torch.dot(r_kplus1_i, r_kplus1_i)
should be altered to num += torch.dot(r_kplus1_i, r_kplus1_i).
In the original computation the numerator num is 0 as far as I understand it.
Best wishes
The text was updated successfully, but these errors were encountered:
Hello,
thank you very much for providing this code. I found it very useful.
I just wondered, whether the computation of beta_k in the cg algorithm in the update step of CGD in the second experiment contains a typo:
I think the line
denom += torch.dot(r_kplus1_i, r_kplus1_i)
should be altered to
num += torch.dot(r_kplus1_i, r_kplus1_i)
.In the original computation the numerator
num
is 0 as far as I understand it.Best wishes
The text was updated successfully, but these errors were encountered: