Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing data files documentation #4

Open
junhonglow opened this issue Nov 17, 2023 · 1 comment
Open

Editing data files documentation #4

junhonglow opened this issue Nov 17, 2023 · 1 comment

Comments

@junhonglow
Copy link
Owner

junhonglow commented Nov 17, 2023

May need clarification on what is incorrect format, from the code it looks like that if the status was anything but OFFERED/UNDECIDED/REJECTED in the JSON file, e.g"ABCDE", it will default to UNDECIDED rather than rejecting the file.
image.png

@nus-se-script
Copy link

nus-se-script commented Nov 20, 2023

Team's Response

Since the purpose of the status field of an applicant is to determine whether to offer or reject the applicant, any other values other than OFFERED, REJECTED, or UNDECIDED are superfluous/extraneous. It is for this reason that our app correctly defaults any unrecognized value for status to UNDECIDED if the user so decides to incorrectly modify the JSON data file.

Rectifying this issue would require us to add additional information in the UG about the acceptable JSON format, which we deem as lower priority compared to the work done in the implementation.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants