Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel execution errors not being rendered in OutputArea #759

Closed
sglyon opened this issue Aug 13, 2024 · 5 comments · Fixed by #769
Closed

Kernel execution errors not being rendered in OutputArea #759

sglyon opened this issue Aug 13, 2024 · 5 comments · Fixed by #769
Assignees

Comments

@sglyon
Copy link

sglyon commented Aug 13, 2024

Hello! I'm using thebe in a project and have run into a snag.

Kernel outputs are shown nicely (including widgets and multimedia) when code succeeds, however when there is a runtime error in the kernel nothing is shown.

I recorded a video clip walking through the error: https://app.screencastify.com/v3/watch/492g6QRsO1NjMOjdrg13

You can also reproduce by

  1. going to the "simple" demo (here or by running the demo via the main branch of this repo)
  2. Activating the kernel
  3. Replacing the input of the code cell with code that would trigger a Python exception (I just put assert False)
  4. Running the code

What you will see is no rendered output in the OutputArea, but you will see the traceback printed to the javascript console

What we want to see is the errors rendered in the OutputArea.

@sglyon
Copy link
Author

sglyon commented Aug 27, 2024

Hi team, sorry to nudge here. If anyone has an idea of where I could start looking I would be happy to attempt a pull request

thanks!

@stevejpurves stevejpurves self-assigned this Aug 28, 2024
@stevejpurves
Copy link
Collaborator

This seems like a regression as previously we have always rendered errors, will take a look @sglyon

@stevejpurves
Copy link
Collaborator

stevejpurves commented Sep 5, 2024

@sglyon fix in place, will go out on next release, hopefully tomorrow

@sglyon
Copy link
Author

sglyon commented Sep 6, 2024

Amazing. Thank you @stevejpurves

I will test this out and hope for the best ;)

@sglyon
Copy link
Author

sglyon commented Sep 6, 2024

Thank you @stevejpurves I just updated based on a build from main and it works great ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants