Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a contributor, I want to use logo of the source tool in the notebook I make #2333

Closed
jravenel opened this issue Oct 23, 2023 · 1 comment · Fixed by #2359, #2361, #2362, #2369 or #2381
Closed
Assignees
Labels
enhancement New feature or request

Comments

@jravenel
Copy link
Contributor

jravenel commented Oct 23, 2023

I want to be able to put the logo at the root of the folder.
Then push/merge and have the logo displayed inside github.
I also need to see this logo inside the Naas Search, and make sure that if I click on the "Open In Naas Lab" button, I have the logo displayed inside the opened notebook in the Lab.

@jravenel jravenel converted this from a draft issue Oct 23, 2023
@jravenel jravenel added the enhancement New feature or request label Oct 23, 2023
@Dr0p42
Copy link
Contributor

Dr0p42 commented Oct 30, 2023

What needs to be done for that

  • Get logos for each tool we have in the project.
  • Store logo .github/assets/logos/ the name of the logo needs to be the name of the directory it will be applied to.
  • Example: For awesome-notebook/Notion it will need to be .github/assets/logos/Notion.png
  • CI/CD: On merge on master we need to:
  • Upload each .github/assets/logos in the S3 bucket arn:aws:s3:::naasai-public
  • Update all notebooks to force the use of the logo stored in .github/assets/logos (use the public link from the S3 bucket). Commit and push.
  • In the json being sent to Algolia, add a image_url (using the S3 public link of the logo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment