Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Safari browser, the jobs section for in JobDefintion page is not visible #449

Closed
funnypenguine opened this issue Oct 29, 2023 · 7 comments · Fixed by #461
Closed

On Safari browser, the jobs section for in JobDefintion page is not visible #449

funnypenguine opened this issue Oct 29, 2023 · 7 comments · Fixed by #461
Assignees
Labels
bug Something isn't working

Comments

@funnypenguine
Copy link

funnypenguine commented Oct 29, 2023

Description

Reproduce

  1. Create a scheduled job, say, run a notebook untitled.ipynb every 2 minutes
  2. After a few minutes when jobs are run, go to Job Definition page
  3. On Chrome browser, you will see jobs that were started by this definition. On Safari, there is no jobs loaded. Both browsers are pointing to the same jupyterlab http://localhost:8888/lab
@funnypenguine funnypenguine added the bug Something isn't working label Oct 29, 2023
@welcome
Copy link

welcome bot commented Oct 29, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@funnypenguine
Copy link
Author

funnypenguine commented Oct 29, 2023

This is the Safari screen shot, where the jobs are not present.

Screenshot 2023-10-28 at 9 47 03 PM

@funnypenguine
Copy link
Author

funnypenguine commented Oct 29, 2023

This is the Chrome Screen shot, where the jobs that belong to the defintion are present.

Screenshot 2023-10-28 at 9 46 49 PM

@JasonWeill
Copy link
Collaborator

@funnypenguine Thank you for opening this issue! What versions of Safari and macOS are you running? In addition, do you see any errors in Safari's developer tools console when you load a job definition detail view?

@funnypenguine
Copy link
Author

I am using MacOS Sonoma 14.0, and Safari Version 17.0 (19616.1.27.211.1). I tried with Safari 16.5, and it didn't work, either. On the Safari dev console, there is no error. On the Network tab, there is a a call to "jobs" endpoint, which returns the response correctly, too. So it looks like the jobs related to the job definition was returned correctly, but just not rendered.

{
"jobs": [
{
"input_filename": "Untitled.ipynb",
"runtime_environment_name": "oss-jup",
"output_formats": [
"html"
],
"job_definition_id": "4ad8b97c-430f-4259-9adc-bfc130b30e8d",
"name": "Untitled",
"output_filename_template": "{{input_filename}}-{{create_time}}",
"job_id": "328e7ff3-265e-4bfc-8772-034966b4e8b8",
"job_files": [
{
"display_name": "HTML",
"file_format": "html"
},
{
"display_name": "Input",
"file_format": "input"
}
],
"url": "/jobs/328e7ff3-265e-4bfc-8772-034966b4e8b8",
"create_time": 1698774968759,
"update_time": 1698774971318,
"start_time": 1698774969619,
"end_time": 1698774971317,
"status": "COMPLETED",
"downloaded": false
},
{
"input_filename": "Untitled.ipynb",
"runtime_environment_name": "oss-jup",
"output_formats": [
"html"
],
"job_definition_id": "4ad8b97c-430f-4259-9adc-bfc130b30e8d",
"name": "Untitled",
"output_filename_template": "{{input_filename}}-{{create_time}}",
"job_id": "36f5b89c-c446-46f4-8dc4-14382bb54e8d",
"job_files": [
{
"display_name": "HTML",
"file_format": "html"
},
{
"display_name": "Input",
"file_format": "input"
}
],
"url": "/jobs/36f5b89c-c446-46f4-8dc4-14382bb54e8d",
"create_time": 1698774848665,
"update_time": 1698774851385,
"start_time": 1698774849583,
"end_time": 1698774851384,
"status": "COMPLETED",
"downloaded": false
}
],
"total_count": 2
}

@funnypenguine
Copy link
Author

Thanks, @JasonWeill. Do you know when this can go in? I tested the fix locally and it worked.

@JasonWeill
Copy link
Collaborator

@funnypenguine I'm coordinating with my team to ensure that this fix doesn't introduce any regressions with Safari or other browsers. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants