Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed jobs are shown as completed when %%time cell magic is used #565

Open
DrMaphuse opened this issue Dec 6, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@DrMaphuse
Copy link

DrMaphuse commented Dec 6, 2024

Description

When a job fails with an exception inside a %%time magic cell, jupyter-scheduler does not recognize that the job actually failed.

For example, this job is shown as completed:
grafik

But the HTML/Notebook output clearly shows that an exception was raised:
grafik

How to reproduce

An exception is raised in a cell with %%time cell magic.

Expected behavior

Jobs where an exception is raised should be shown as failed, even when magic commands are used.

Context

  • Operating System and version: Linux Ubuntu 20.04
  • JupyterLab version: 4.0.11
  • Jupyter Scheduler version: 2.4.0
@DrMaphuse DrMaphuse added the bug Something isn't working label Dec 6, 2024
@andrii-i
Copy link
Collaborator

andrii-i commented Dec 6, 2024

Hi @DrMaphuse. Thank you for creating this issue.

Couple of questions: is it correct that this is only seen with in-notebook cell errors? Is it always the same type of error or not really?

@DrMaphuse
Copy link
Author

This happens with errors raised in an upstream module that is installed in editable mode. So far it has always been the same type of error I believe, but I can dig a little further and look if there are others.

@DrMaphuse
Copy link
Author

DrMaphuse commented Dec 20, 2024

I have managed to reproduce the bug, and it is actually quite simple:

When an exception is raised in a cell with %%time cell magic, the job is falsely shown as completed by the scheduler:

grafik

Adjusted the title accordingly.

@DrMaphuse DrMaphuse changed the title Failed jobs are sometimes shown as completed Failed jobs are shown as completed when %%time cell magic is used Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants