Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lighthouse CI App integration for nicer checks display? #582

Open
krassowski opened this issue Dec 30, 2021 · 1 comment
Open

Enable Lighthouse CI App integration for nicer checks display? #582

krassowski opened this issue Dec 30, 2021 · 1 comment

Comments

@krassowski
Copy link
Member

Currently the lighthouse result show up as:

Total size of all the files uploaded is 1165820 bytes
Finished uploading artifact lighthouse-results. Reported size is 1165820 bytes. There were 0 items that failed to upload
Uploading median LHR of http://localhost:45821/about.html...success!
Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1640813497053-27107.report.html
Uploading median LHR of http://localhost:45821/binder.html...success!
Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1640813497456-16487.report.html
Uploading median LHR of http://localhost:45821/community.html...success!
Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1640813497852-78305.report.html
Uploading median LHR of http://localhost:45821/documentation.html...success!
Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1640813498306-7357.report.html
Uploading median LHR of http://localhost:45821/hub.html...success!
Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1640813498846-65386.report.html
No GitHub token set, skipping GitHub status check.
Dumping 5 reports to disk at /home/runner/work/jupyter.github.io/jupyter.github.io/.lighthouseci...
Done writing reports to disk.

Error: 2 results for http://localhost:45821/about.html
Report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1640813497053-27107.report.html

categories.accessibility failure for minScore assertion
Expected >= 0.95, but found 0.94

categories.best-practices failure for minScore assertion
Expected >= 0.95, but found 0.93
Error: 2 results for http://localhost:45821/binder.html
Report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1640813497456-16487.report.html

categories.accessibility failure for minScore assertion
Expected >= 0.95, but found 0.85

categories.seo failure for minScore assertion
Expected >= 0.95, but found 0.92
Error: 1 result for http://localhost:45821/documentation.html
Report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1640813498306-7357.report.html

categories.accessibility failure for minScore assertion
Expected >= 0.95, but found 0.94

But we could go fancy and have:

image

This would require authorizing https://github.com/apps/lighthouse-ci ; it is tied to a private account of maintainer but also mentioned on https://github.com/GoogleChrome/lighthouse-ci/blob/main/docs/getting-started.md#github-status-checks.

Just an option - I don't have opinion on this one.

Originally posted by @krassowski in #579 (comment)

@krassowski krassowski changed the title Enable Lighthouse CI App integration for nicer checks displat? Enable Lighthouse CI App integration for nicer checks display? Dec 30, 2021
@palewire palewire added this to the Streamline the site milestone Dec 31, 2021
@palewire palewire removed this from the Streamline the site milestone Jan 14, 2022
@HarshCasper
Copy link

Hi @krassowski 👋

I had an attempt to work on this! Here is the PR: #692

It would remove the need to have a LightHouse CI App to be installed and the CI workflow can directly put up a comment over the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants