diff --git a/CHANGELOG.md b/CHANGELOG.md index 356848089..2d80a46ca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,39 @@ +## 1.1.0 + +([Full Changelog](https://github.com/jupyter/nbclassic/compare/v1.0.0...991361437fe0e51da639775f5fbe709cc8212278)) + +### Enhancements made + +- Add issue templates to repository [#258](https://github.com/jupyter/nbclassic/pull/258) ([@RRosio](https://github.com/RRosio)) + +### Bugs fixed + +- Make terminals_available false if key is not in settings dict yet [#261](https://github.com/jupyter/nbclassic/pull/261) ([@RRosio](https://github.com/RRosio)) + +### Maintenance and upkeep improvements + +- fix: trust new notebooks and notebooks with new cells [#275](https://github.com/jupyter/nbclassic/pull/275) ([@maartenbreddels](https://github.com/maartenbreddels)) +- Fix ci end-to-end tests [#274](https://github.com/jupyter/nbclassic/pull/274) ([@maartenbreddels](https://github.com/maartenbreddels)) +- Fix `Linux JS Test` CI job [#269](https://github.com/jupyter/nbclassic/pull/269) ([@krassowski](https://github.com/krassowski)) +- Update dependency requirements to minimum necessary [#259](https://github.com/jupyter/nbclassic/pull/259) ([@RRosio](https://github.com/RRosio)) + +### Documentation improvements + +- Adding pydata_sphinx_theme to environment.yml file for docs build [#262](https://github.com/jupyter/nbclassic/pull/262) ([@RRosio](https://github.com/RRosio)) +- Fix links for check_release links CI job [#260](https://github.com/jupyter/nbclassic/pull/260) ([@RRosio](https://github.com/RRosio)) +- Port to PyData-Sphinx Theme [#256](https://github.com/jupyter/nbclassic/pull/256) ([@RRosio](https://github.com/RRosio)) + +### Contributors to this release + +([GitHub contributors page for this release](https://github.com/jupyter/nbclassic/graphs/contributors?from=2023-05-04&to=2024-05-24&type=c)) + +[@jph00](https://github.com/search?q=repo%3Ajupyter%2Fnbclassic+involves%3Ajph00+updated%3A2023-05-04..2024-05-24&type=Issues) | [@krassowski](https://github.com/search?q=repo%3Ajupyter%2Fnbclassic+involves%3Akrassowski+updated%3A2023-05-04..2024-05-24&type=Issues) | [@maartenbreddels](https://github.com/search?q=repo%3Ajupyter%2Fnbclassic+involves%3Amaartenbreddels+updated%3A2023-05-04..2024-05-24&type=Issues) | [@RRosio](https://github.com/search?q=repo%3Ajupyter%2Fnbclassic+involves%3ARRosio+updated%3A2023-05-04..2024-05-24&type=Issues) + + + ## 1.0.0 ([Full Changelog](https://github.com/jupyter/nbclassic/compare/v0.5.6...109a62153a74bae9a38f0c4bec460a91429f0c19)) @@ -20,8 +53,6 @@ [@echarles](https://github.com/search?q=repo%3Ajupyter%2Fnbclassic+involves%3Aecharles+updated%3A2023-04-27..2023-05-04&type=Issues) - - ## 0.5.6 ([Full Changelog](https://github.com/jupyter/nbclassic/compare/v0.5.5...ddbbf579a904ef1c040f3221f7dd64d287323636)) diff --git a/docs/source/examples/Notebook/Distributing Jupyter Extensions as Python Packages.ipynb b/docs/source/examples/Notebook/Distributing Jupyter Extensions as Python Packages.ipynb index 4be20b7ce..10be06259 100644 --- a/docs/source/examples/Notebook/Distributing Jupyter Extensions as Python Packages.ipynb +++ b/docs/source/examples/Notebook/Distributing Jupyter Extensions as Python Packages.ipynb @@ -134,7 +134,7 @@ "\n", "> Of course, in addition to the files listed, there are number of other files one needs to build a proper package. Here are some good resources:\n", "- [The Hitchhiker's Guide to Packaging](https://the-hitchhikers-guide-to-packaging.readthedocs.io/en/latest/quickstart.html)\n", - "- [Repository Structure and Python](https://kenreitz.org/essays/2013/01/27/repository-structure-and-python) by Kenneth Reitz\n", + "- [Repository Structure and Python](https://kennethreitz.org/essays/2013/repository_structure_and_python) by Kenneth Reitz\n", "\n", "> How you distribute them, too, is important:\n", "- [Packaging and Distributing Projects](https://python-packaging-user-guide.readthedocs.io/tutorials/distributing-packages/)\n", diff --git a/docs/source/nbclassic.rst b/docs/source/nbclassic.rst index f75e7ba18..58d8dd1df 100644 --- a/docs/source/nbclassic.rst +++ b/docs/source/nbclassic.rst @@ -90,3 +90,19 @@ if available at the `Jupyterlab-contrib website `_ is a +known issue with partial fix `Support nbclassic while updating the static path `_ +pending to be merged into the `Jupyter-contrib/jupyter_nbextensions_configurator `_ repository. + + Once a release with this fix is available, users will be able to activate the extension with the following commands:: + + $ pip install 'jupyter_nbextensions_configurator @ git+https://github.com/datalayer-externals/jupyter-notebook-configurator.git@fix/nbclassic#egg=jupyter_nbextensions_configurator' + $ jupyter nbclassic-extension install --sys-prefix --py jupyter_nbextensions_configurator --overwrite + $ jupyter nbclassic-extension enable --sys-prefix --py jupyter_nbextensions_configurator + $ jupyter nbclassic-serverextension enable --sys-prefix --py jupyter_nbextensions_configurator diff --git a/docs/source/nbclassic_dev_faq.rst b/docs/source/nbclassic_dev_faq.rst index b9e8516f6..5cac94074 100644 --- a/docs/source/nbclassic_dev_faq.rst +++ b/docs/source/nbclassic_dev_faq.rst @@ -72,20 +72,3 @@ NbClassic Developer FAQ .. _`allowed organization list`: https://github.com/MeeseeksBox/MeeseeksDev/blob/master/meeseeksdev/__init__.py#L26 .. _`Jupyter Community`: https://jupyter.org/community - -Known issues ------------- - -Bellow are some known bugs and issues with the NbClassic project. These are items that may be of particular interest to users -migrating from notebook to nbclassic. - -1. `#140 Error using jupyter_nbextensions_configurator with nbclassic `_ is a -known issue with partial fix `Support nbclassic while updating the static path `_ -pending to be merged into the `Jupyter-contrib/jupyter_nbextensions_configurator `_ repository. - - Once a release with this fix is available, users will be able to activate the extension with the following commands:: - - $ pip install 'jupyter_nbextensions_configurator @ git+https://github.com/datalayer-externals/jupyter-notebook-configurator.git@fix/nbclassic#egg=jupyter_nbextensions_configurator' - $ jupyter nbclassic-extension install --sys-prefix --py jupyter_nbextensions_configurator --overwrite - $ jupyter nbclassic-extension enable --sys-prefix --py jupyter_nbextensions_configurator - $ jupyter nbclassic-serverextension enable --sys-prefix --py jupyter_nbextensions_configurator diff --git a/nbclassic/_version.py b/nbclassic/_version.py index f4951f767..9a8750e1e 100644 --- a/nbclassic/_version.py +++ b/nbclassic/_version.py @@ -5,7 +5,7 @@ import re # Version string must appear intact for tbump versioning -__version__ = '1.1.0.dev0' +__version__ = '1.2.0.dev0' # Build up version_info tuple for backwards compatibility pattern = r'(?P\d+).(?P\d+).(?P\d+)(?P.*)' diff --git a/nbclassic/static/base/js/namespace.js b/nbclassic/static/base/js/namespace.js index 9f3deb03d..d7b1ee816 100644 --- a/nbclassic/static/base/js/namespace.js +++ b/nbclassic/static/base/js/namespace.js @@ -73,7 +73,7 @@ define(function(){ // tree jglobal('SessionList','tree/js/sessionlist'); - Jupyter.version = "1.1.0.dev0"; + Jupyter.version = "1.1.0"; Jupyter._target = '_blank'; return Jupyter; diff --git a/nbclassic/static/notebook/js/clipboard.js b/nbclassic/static/notebook/js/clipboard.js index fe4bab90a..725e6d405 100644 --- a/nbclassic/static/notebook/js/clipboard.js +++ b/nbclassic/static/notebook/js/clipboard.js @@ -74,8 +74,8 @@ function paste(event) { } } first_inserted.focus_cell(); + event.preventDefault(); } - event.preventDefault(); } function notebookOnlyEvent(callback) { diff --git a/pyproject.toml b/pyproject.toml index e9fc19a24..b2bd8cc47 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -28,7 +28,7 @@ post-version-spec = "dev" ignore-glob = ["docs/source/examples/Notebook/Working With Markdown Cells.ipynb", "docs-translations/**/README.md", "docs/source/contributing.rst", "docs/source/examples/Notebook/JavaScript Notebook Extensions.ipynb", "CHANGELOG.md", "nbclassic/static/components/**/*.*"] [tool.tbump.version] -current = "1.1.0.dev0" +current = "1.2.0.dev0" regex = ''' (?P\d+)\.(?P\d+)\.(?P\d+) ((?Pa|b|rc|.dev)(?P\d+))? diff --git a/setupbase.py b/setupbase.py index 80f28b6eb..4e7a4feec 100644 --- a/setupbase.py +++ b/setupbase.py @@ -12,7 +12,7 @@ import os import re -import pipes +import shlex import shutil import sys @@ -27,7 +27,7 @@ from subprocess import list2cmdline else: def list2cmdline(cmd_list): - return ' '.join(map(pipes.quote, cmd_list)) + return ' '.join(map(shlex.quote, cmd_list)) #------------------------------------------------------------------------------- # Useful globals and utility functions @@ -486,7 +486,7 @@ def run(self): try: run(['lessc', '--source-map', - '--include-path=%s' % pipes.quote(static), + '--include-path=%s' % shlex.quote(static), src, dst, ], cwd=repo_root, env=env)