Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL+F/CMD+F overrides browser's Find function with custom code #7380

Open
JasonWeill opened this issue May 23, 2024 · 1 comment
Open

CTRL+F/CMD+F overrides browser's Find function with custom code #7380

JasonWeill opened this issue May 23, 2024 · 1 comment
Labels

Comments

@JasonWeill
Copy link
Collaborator

Description

When the user presses CTRL+F or CMD+F, custom JupyterLab code for Find appears. This behavior differs from the classic notebook (https://github.com/jupyter/nbclassic/) which does not override these shortcut keys, and which instead allows the browser's built-in search bar to be displayed and used.

Expected behavior

By default, in Notebook 7, CTRL+F or CMD+F should cause the browser's default search user interface to display.

Context

This was spun off from #7041, originally filed by @jph00.

Jupyter Notebook should not override browsers' built-in keyboard shortcuts, wherever possible.

Virtual rendering may cause the browser's search box to search only a portion of the notebook; unrendered cells may not be made available to the browser.

@JasonWeill JasonWeill added bug status:Needs Triage Applied to issues that need triage labels May 23, 2024
@RRosio RRosio removed the status:Needs Triage Applied to issues that need triage label May 28, 2024
@jtpio
Copy link
Member

jtpio commented May 30, 2024

Jupyter Notebook should not override browsers' built-in keyboard shortcuts, wherever possible.

Yes this used to be the case before: #6905 (comment)

Virtual rendering may cause the browser's search box to search only a portion of the notebook; unrendered cells may not be made available to the browser.

This was indeed changed in #6905 because of the new implementation of the notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants