-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ANSI color code 3 mapping from brown
to gold
and set bold format processing enabled by default
#611
Conversation
Hi @dalthviz can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsbautista ! Checked this manually and is working as expected 👍 Just in case, added a suggestion related with the failing test with a possible fix for it.
Also, thinking about tests, probably it could be nice to update the TestAnsiCodeProcessor
test class here to also have an instance of QtAnsiCodeProcessor
. In that way we could check the actual color that gets rendered over the console. A possible way to achieve that is:
- Add a
qt_processor
attribute to theTestAnsiCodeProcessor
of typeQtAnsiCodeProcessor
over thesetUp
method - Use it over the test you modified to check for the color name with something like:
foreground_color = self.processor.foreground_color
self.assertEqual(self.qt_processor.get_color(foreground_color).name(), '#ffd700')
Let me know what you think and if you have any question!
Edit: Also, lets do here the change for the default value to allow bold format and add a test for it. For more details about what needs to be done you can check #273 (comment)
brown
to gold
Co-authored-by: Daniel Althviz Moré <[email protected]>
…ista/qtconsole into boldfacedTextOutputYellow
Co-authored-by: Daniel Althviz Moré <[email protected]>
brown
to gold
brown
to gold
and set bold format enabled by default
brown
to gold
and set bold format enabled by defaultbrown
to gold
and set bold format processing enabled by default
Thanks for getting in the suggestions @jsbautista ! Left a single final suggestion to remove some extra blank lines. Also, doing the change to enable bold format by default (following the info at #273 (comment)) needs to be done. Once those two things are done here I would say this should be ready for merging 👍 Just in case, what do you think @ccordoba12 ? |
Co-authored-by: Daniel Althviz Moré <[email protected]>
…ista/qtconsole into boldfacedTextOutputYellow
brown
to gold
and set bold format processing enabled by defaultbrown
to gold
and set bold format processing enabled by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsbautista !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too, thanks @jsbautista!
brown
to gold
and set bold format processing enabled by defaultbrown
to gold
and set bold format processing enabled by default
After:
Fixes #273
Related to spyder-ide/spyder#21225