[WIP] Dark Mode Tweaks #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bollwyvl
commented
Aug 17, 2019
| @@ -176,6 +176,8 @@ code { | |||
|
|
|||
| .jp-scribe-menu-content { | |||
| padding: 5px 12px 12px 12px; | |||
| background-color: var(--jp-layout-color2); | |||
There was a problem hiding this comment.
Note this is after a reload on binder without the previous menu bar fix... will re-screenshot from demo binder.
|
Thank you so much for working on this! I was just about to post an issue for all the dark mode mishaps, so I'll note that you're already fixing many of the problems I found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing with this on binder: looking great!
With the stock JupyterLab dark theme, after highlighting a prosemirror and then selecting another cell, the unselected editor has white-on-white text.
This just sets the background to transparent.
Could use a
var(--jp-, but it seems like less is probably more, if the goal is trying to make the editing experience feel seamless, this should be the most predictable across themes. Just unsetting it inherits some other styling which disappears when you actually select it. Not nice.Will keep investigating some other things!
wip binder: