Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the move line show that it is not a drag element, but a simple HTML Element. #299

Open
ghost opened this issue Aug 28, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Aug 28, 2020

Describe the new feature being added
To simplify our code we should have it the move line be a simple HTML element, rather than a drag element.

How will this feature improve this extension

Rendering the move line by making it a drag element will be confusing too future developers when they are looking at the codebase. This is because the move line doesn't actually get dragged on the page. It gets moved in discrete chunks when we cross the boundary of a row or column. It is more intuitive that this would be the job of a simple HTML element.

@ghost ghost added the enhancement New feature or request label Aug 28, 2020
@ghost ghost changed the title Refactor the move line show that it is not a drag element, but a simple virtual element. Refactor the move line show that it is not a drag element, but a simple HTML Element. Aug 28, 2020
@ghost ghost added this to the 1.0 milestone Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

0 participants