Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't launch repos in mybinder.org UI: Uncaught TypeError: URL constructor: /build/gh/binder-examples/conda/HEAD is not a valid URL. #1747

Closed
manics opened this issue Sep 24, 2023 · 2 comments
Labels

Comments

@manics
Copy link
Member

manics commented Sep 24, 2023

Bug description

I had to revert jupyterhub/mybinder.org-deploy#2746 (which includes #1741) as it causes a Javascript error on the main mybinder.org page. This seems to prevent launching any repository.

How to reproduce

The occurred after entering https://github.com/binder-examples/conda into mybinder.org (deployment has since been reverted and is working again). It failed to launch, and this error was in the browser console:

Uncaught TypeError: URL constructor: /build/gh/binder-examples/conda/HEAD is not a valid URL.

The browser debugger indicated

let apiUrl = new URL(this.baseUrl + "build/" + this.providerSpec);

is the source

image

Note this is not reproducible using the test configurations in https://github.com/jupyterhub/binderhub/tree/main/testing

@yuvipanda
Copy link
Collaborator

Sorry about missing this @manics. I've now opened #1758, which starts adding JS unit tests here as well. There's going to be a bit of work needed before the unit tests can 'fully' catch things, but it's a start.

@yuvipanda
Copy link
Collaborator

This has since been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants