Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar versioning: Use Helm chart versions YYYY.MM.DD-HHMMSS-gGITCOMMIT #1797

Closed
manics opened this issue Nov 25, 2023 · 0 comments
Closed

Comments

@manics
Copy link
Member

manics commented Nov 25, 2023

Proposed change

BinderHub effectively works as a continuously deployable repository, where every merge is deployable. However we still have some tags, and there is an open issue about a 1.0.0 release.

What do you think about formalising this "always deployable" state of BinderHub and treating every merge as a mini release? The artefacts from this repository are the container images and the Helm chart.

This either means forgetting about tags completely, the Helm Chart versions are the definitive record of versions, or automatically creating tags corresponding to the Helm Chart version after every merge and disable any workflows triggered by tags.

This requires adding an option to chartpress to get YYYY.MM.DD-HHMMSS from the last commit (which should be a merge commit created by GitHub, so should always have a reliable timestamp).

The reason for keeping the git commit in YYYY.MM.DD-HHMMSS-gGITCOMMIT is to easily tie it back to the source commit.

Alternatively we could change the first part to YYYY.MM.DDHHMMSS which means we can also use that for the PyPI package version if we wanted to push it.

Related issues:

@manics manics closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant