Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.2.0 to flush out whats merged? #4917

Closed
consideRatio opened this issue Oct 1, 2024 · 2 comments · Fixed by #4918
Closed

Release 5.2.0 to flush out whats merged? #4917

consideRatio opened this issue Oct 1, 2024 · 2 comments · Fixed by #4918

Comments

@consideRatio
Copy link
Member

consideRatio commented Oct 1, 2024

@benz0li asked in jupyterhub/zero-to-jupyterhub-k8s#3406 (comment) for a release with dark mode toggle. We currently have z2jh and tljh beta releases out - is flushing 5.2.0 (with dark mode toggle, and more?) ok to do @minrk?

@benz0li
Copy link
Contributor

benz0li commented Oct 1, 2024

@minrk
Copy link
Member

minrk commented Oct 1, 2024

While I think it's fine to make a release with what we have, I really want to push back very hard on the amount of work we are creating for ourselves in making these distribution releases. I feel very strongly that preparing a release for a distribution should not trigger a bunch of work to release dependencies as well. Either they are ready (i.e. already released) or they are not and should wait for the next distribution release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants