-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from dockerhub to quay.io (and consider we got an 800$ charge!) #688
Comments
Cc @consideRatio and @mathbunnyru who lead that work |
Was @choldgraf's card charged and is it now removed so it can't be charged going onards? |
👍 to moving everything to quay and leaving docker. I don't think anything's been charged, but let's make sure we don't give them a chance to charge in the future. |
I see this charge on the I think I understand what's going on. https://www.docker.com/community/open-source/application/
And, based on this message, it was exactly one year ago when the upgrade to Docker Team happened. |
👍 to moving the I will work on |
Could we push the important images (mostly jupyterhub) to both docker hub and quay.io for a release cycle or two, but update all docs, config and example repos to use quay.io? That'll ensure anyone pulling/checking |
I've sent a support request to Docker asking them WTF is going on. I'll let you all know if I hear back. I definitely agree we should just leave the platform because this is too much hassle if there are alternatives that work just as well. I'd suggest we:
|
I don't think we need another year of service (though there's no harm if someone wants to apply). It means people may hit the rate limits when pulling, but hopefully that means they'll look at the readme and see that they should move to quay.io |
I built a small tool that'll migrate some but not all tagged images across the registries! https://github.com/yuvipanda/move-off-dockerhub. I've moved I'll do this for all the z2jh and chp images, and the JupyterHub ones as well. @manics we can do this in reverse for a bit to dockerhub as well. |
@yuvipanda please, change the email of the jupyterhub quay.io account to |
After 2 days of work with ~25 commits, I've finally switched http://github.com/jupyter/docker-stacks/ to Quay.io. Cool features work fine too - automatic registry description update, Nice features of Quay.io I noticed:
Things I don't like/don't work:
|
See jupyterhub/team-compass#688 for context. I've also added `QUAY_USERNAME` and `QUAY_PASSWORD` to environment secrets, but *not* `env.REGISTRY`. I will do so once this gets merged.
See jupyterhub/team-compass#688 for context. I've also added `QUAY_USERNAME` and `QUAY_PASSWORD` to environment secrets, but *not* `env.REGISTRY`. I will do so once this gets merged.
I have copied this image with `skopeo` Ref jupyterhub/team-compass#688
I went ahead and applied for another year of Open Source account status with DockerHub, and got an e-mail that it was approved today. Could somebody confirm that we do in-fact have this status now? |
I received an email yesterday:
🤷🏽 |
At least once the JupyterHub image moves are complete, we should go to all the READMEs in the jupyterhub dockerhub and write them out as redirects. |
I've also put in appropriate secrets for QUAY_USERNAME and QUAY_PASSWORD Ref jupyterhub/team-compass#688
Bump up a couple other versions in the Dockerfile examples as well. Ref jupyterhub/team-compass#688
Ok, everything that needs a PR now has a PR :) Reviews would be appreciated! |
I appreciate the move to quay.io and everyone's effort to make this happen. I just came across this update by chance, noticing the reference to quay.io in the docs, and I'm wondering about the scope of the migration strategy. Specifically I noticed that, as of writing this, only the images tagged with python-3.11 are available from the quay.io repo. For example, docker.io/jupyter/datascience-notebook:python-3.10.11 does not seem to be available on quay.io. Is this intended? If yes, what is the policy going forward as to which Python versions will be built/provided on quay.io v.s. docker hub, or will the latter be shut down, that is all previous images would be removed? Thank you |
@mathbunnyru just as I moved old jupyterhub images to quay.io, I want to move old jupyter/docker-stacks images as well. Do you have objections to that? |
I have a few:
I didn’t want this mess to be present in Quay.io. @miraculixx answering your questions. I intentionally didn’t push old images to Quay.io, mostly for the reasons mentioned above. |
@mathbunnyru what do you think about migrating just the "old" images mentioned on https://jupyter-docker-stacks.readthedocs.io/en/latest/#using-old-images? |
I think that’s a good idea. |
@manics @yuvipanda @miraculixx done in jupyter/docker-stacks#2032 In a few days I will update the table and the information about using Docker Hub for old images. Update: done |
Can someone else move the manifests / descriptions from dockerhub to quay.io? I don't think I'll have time to do that, manually or automatically, for at least another week or so :( |
@yuvipanda done for 4 images in jupyterhub repo, please, take a look: jupyterhub/jupyterhub#4634 |
Did you intentionally omit the arm64 images when copying the old docker-stack images? |
Nope, that's a bug, thank you! Do you maybe know an easy way to fix this? I know this solution:
Update: Implemented this solution: jupyter/docker-stacks#2035 |
@yuvipanda suggested using |
@manics thanks. I fixed the problem. |
I'd like to publish to both DockerHub and Quay.io instead of switching over fully, is that okay? Both of these container registries are free services under no obligation to stay functional and free for us to publish to and users to pull from, so it could make sense to publish images to more than one container registry to allow us to switch over if there are issues for some or all users. Publishing to both seems like a kinder transition than to stop publishing to docker hub, as that doesn't break workflows like building and using a custom image for each release. As an example, here is a PR for configurable-http-proxy that accomplishes this, its a minimal change that will only add the extra upload time. |
If there are no objections, I'd like to help all repos publish to Docker Hub alongside Quay.io. Repos to publish to both Docker Hub and Quay.io
|
I think it makes sense to publish JupyterHub and CHP to both since they're the base images that people use directly. Z2JH and perhaps BinderHub makes sense from the perspective of redundancy. I don't think we should bother with repo2docker though since we made the switch a long time ago and we're beyond the point where people still expect to find it on Docker Hub. I also don't see the point of pushing mybinder.org-deploy to both registries. It's our production deployment which we fully control, and although it's a good example of how to go about deploying a mybinder type service there's no expectation that it'll work for anyone else. The registry serves the purpose of being an internal container distribution service amongst the mybinder federation members which just happens to be public. |
I agree with @manics on most points. I don't really see the benefit for the helm chart images, since those aren't images that users use directly, the URLs are internal to the chart. So my inclination would be just the standalone images that haven't migrated long ago, (i.e. just jupyterhub and chp, I think). |
+1 to what @minrk and @manics said. I think it will help move people away from dockerhub, towards quay.io. For people who are inheriting from one of the k8s images, to bump up version numbers they have to change the I'm also personally kinda pissed off and disappointed at dockerhub, given this is like the 3rd or 4th time (since this) I've been part of a community effort scrambling to try to figure out if we need to move off it or not, and it eventually 'working out' that an imminent move is not exactly needed - feels a little bit like hostage taking, and I don't wanna do that again. So, from an ideological perspective, I would like us to maintain as minimal a presence on dockerhub as possible, and make sure that our primary registry is quay.io. |
How about if we only push Z2JH releases to Docker Hub? I think that's a nice compromise between not supporting Docker Hub, whilst still allowing some flexibility and redundancy for admins. |
Given @consideRatio has already done the work in a bunch of PRs, I want to respect that. Perhaps what we can do is:
I think this eases users out, which I think is @consideRatio's original goal in making these PRs. I think any org that allows pulling from dockerhub will also allow pulling from quay.io (or GitHub registry), so I think the long term flexibility is not that limited. How does this sound? |
That all sounds great and sensible, thanks @consideRatio and @yuvipanda! |
👍 for use GitHub's ghcr.io as the secondary container registry, I've already used it a bit in the dask org for dask-gateway, its worked out fine and has some nice features related to permission control for example. There are some relevant notes about this in this long post, copied here for future reference:
|
My feeling is we shouldn't spend too much time investigating this:
|
@choldgraf's card is apparently attached to the jupyterhub org on dockerhub, and it just got an 800$ charge!
This is not supposed to happen, as we have 'sponsored oss' status (I'm not sure who got that for us, but THANK YOU to whoever that was).
While I guess this charge is a mistake on their part, it at least feels sufficient motivation for me to move us completely over to quay.io. We already moved repo2docker (jupyterhub/repo2docker#1076 (comment)), and while I can't find the issue right now, the 'sponsored OSS' status was why we didn't move everything else. Time to move it now I think.
Repos to move
The text was updated successfully, but these errors were encountered: