Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align CSS classnames definition #149

Open
fcollonval opened this issue Feb 14, 2021 · 1 comment
Open

Align CSS classnames definition #149

fcollonval opened this issue Feb 14, 2021 · 1 comment

Comments

@fcollonval
Copy link
Member

...the documentation seemed to indicated that they were moving away from that practice: "CSS classnames are defined inline in the code. We used to put them as all caps file-level consts, but we are moving away from that." (https://jupyterlab.readthedocs.io/en/stable/developer/css.html)

Originally posted by @adpatter in #148 (comment)

It would be good to align the example with the JupyterLab recommendation
@adpatter
Copy link
Contributor

I'll do this in the next PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fcollonval @adpatter