Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev install on CI times out #1138

Closed
dlqqq opened this issue Dec 4, 2024 · 7 comments · Fixed by #1139
Closed

Dev install on CI times out #1138

dlqqq opened this issue Dec 4, 2024 · 7 comments · Fixed by #1139
Labels
bug Something isn't working

Comments

@dlqqq
Copy link
Member

dlqqq commented Dec 4, 2024

Description

See the 42-minute workflow run in #1129: https://github.com/jupyterlab/jupyter-ai/actions/runs/12167591800/job/33939176577?pr=1129

Relevant logs below:

@jupyter-ai/core: INFO: This is taking longer than usual. You might need to provide the dependency resolver with stricter constraints to reduce runtime. See https://pip.pypa.io/warnings/backtracking for guidance. If you want to abort this run, press Ctrl + C.
@jupyter-ai/core: INFO: pip is still looking at multiple versions of langchain-nvidia-ai-endpoints to determine which version is compatible with other requirements. This could take a while.
@jupyter-ai/core:   Downloading langchain_nvidia_ai_endpoints-0.2.1-py3-none-any.whl.metadata (9.3 kB)
@jupyter-ai/core: INFO: This is taking longer than usual. You might need to provide the dependency resolver with stricter constraints to reduce runtime. See https://pip.pypa.io/warnings/backtracking for guidance. If you want to abort this run, press Ctrl + C.
@jupyter-ai/core:   Downloading langchain_nvidia_ai_endpoints-0.2.0-py3-none-any.whl.metadata (9.4 kB)
@jupyter-ai/core: ERROR: Exception:
@jupyter-ai/core: Traceback (most recent call last):
@jupyter-ai/core:   File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 105, in _run_wrapper
@jupyter-ai/core:     status = _inner_run()
@jupyter-ai/core:   File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 96, in _inner_run
@jupyter-ai/core:     return self.run(options, args)
@jupyter-ai/core:   File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 67, in wrapper
@jupyter-ai/core:     return func(self, options, args)
@jupyter-ai/core:   File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 379, in run
@jupyter-ai/core:     requirement_set = resolver.resolve(
@jupyter-ai/core:   File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 95, in resolve
@jupyter-ai/core:     result = self._result = resolver.resolve(
@jupyter-ai/core:   File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/pip/_vendor/resolvelib/resolvers.py", line 546, in resolve
@jupyter-ai/core:     state = resolution.resolve(requirements, max_rounds=max_rounds)
@jupyter-ai/core:   File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/pip/_vendor/resolvelib/resolvers.py", line 457, in resolve
@jupyter-ai/core:     raise ResolutionTooDeep(max_rounds)
@jupyter-ai/core: pip._vendor.resolvelib.resolvers.ResolutionTooDeep: 200000
@jupyter-ai/core: 
@dlqqq dlqqq added the bug Something isn't working label Dec 4, 2024
@dlqqq dlqqq changed the title CI is taking a ridiculous amount of time to dev-install Jupyter AI Dev install on CI times out Dec 4, 2024
@krassowski
Copy link
Member

Can you try pinning jupyterlab to 4.3.1? I wonder if it has to do with httpx pin.

@dlqqq
Copy link
Member Author

dlqqq commented Dec 4, 2024

@krassowski Wow, that did fix it, incredible! I managed to reproduce the issue locally. I then ran micromamba install jupyterlab==4.3.1 and re-ran jlpm dev-install, and it worked much more quickly.

Thank you for reaching out, I would've gone crazy figuring this out myself.

Is there an issue for this?

@krassowski
Copy link
Member

jupyterlab/jupyterlab#17035

@krassowski
Copy link
Member

krassowski commented Dec 4, 2024

Not sure about langchain_nvidia_ai_endpoints but langserve and friends were broken by the new httpx release too. We need to release a new patch on lab to allow either old or new httpx version or to drop it altogether, we discussed it on frontends meeting today I think it's already on YouTube

@ibdafna
Copy link
Member

ibdafna commented Dec 4, 2024

FYI also running into this issue internally

@krassowski
Copy link
Member

It's 11pm for me so I cannot get a quick fix right now but if anyone has time to PR version sniffing or removal of httpx in the meantime I can review and cut a patch release in the morning

@dlqqq
Copy link
Member Author

dlqqq commented Dec 5, 2024

@krassowski IDK anybody who works as hard as you 😂, make sure to get enough sleep! I haven't opened a PR because I think there's still some ambiguity on what approach works best. I've left my thoughts in a new comment on that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants