You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With JupyterLab #15344 the ability to add an error animation to a code call was added.
It should be relatively straight forward to allow the jupyter-ai completers to enable this functionality.
Problem
The jupyter-ai error reporting on inline completion differs from jupyterlab completer. Currently jupyterlab shows a flashing icon in the cell, while jupyter-ai has a notification warning
Proposed Solution
I propose allowing jupyter-ai to emit the error field when there is an error in the generation process. I am not sure if this should be in place of the error notification, or alongside of it. The benefit of keeping it alongside the current notification would be that the current notification gives more context.
Additional context
The text was updated successfully, but these errors were encountered:
Hi @andrewfulton9
I wanted to let you know that I used your branch as a reference while working on this issue. It provided a good starting point!
I've submitted a PR trying to address this issue and would really appreciate it if you could take a look and provide some feedback.
Link to PR: #1197
Hi @andrewfulton9
I just wanted to know whether you saw the error animation in code cell after returning item containing error field from fetch function of JaiInlineProvider. Because I am having some issues with jupyterlab after installing jupyter-ai. I am seeing some version incompatible issues in console and the code changes in jupyterlab aren't being reflected. Could you let me know if you faced the same issue. Or how you approached this?
I think the code here is your problem. The results with the error field are never actually returned to the inline-completer as it is in your PR currently. If you remove the code I linked. I think it should work.
Here is a messy branch that I was using for testing locally.
With JupyterLab #15344 the ability to add an error animation to a code call was added.
It should be relatively straight forward to allow the jupyter-ai completers to enable this functionality.
Problem
The jupyter-ai error reporting on inline completion differs from jupyterlab completer. Currently jupyterlab shows a flashing icon in the cell, while jupyter-ai has a notification warning
Proposed Solution
I propose allowing jupyter-ai to emit the error field when there is an error in the generation process. I am not sure if this should be in place of the error notification, or alongside of it. The benefit of keeping it alongside the current notification would be that the current notification gives more context.
Additional context
The text was updated successfully, but these errors were encountered: