Skip to content

Commit 61fbada

Browse files
authored
Merge pull request #758 from jupyterlab/release-v4.0.12-1
Release v4.0.12-1
2 parents fba90b6 + 5aa4e61 commit 61fbada

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,3 @@ __pycache__
2525

2626
env_installer/jlab_server/
2727
env_installer/jlab_server.tar.gz
28-

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ JupyterLab Desktop is the cross-platform desktop application for [JupyterLab](ht
88

99
If you have an existing JupyterLab Desktop installation, please uninstall it first by following the [uninstall instructions](user-guide.md#uninstalling-jupyterlab-desktop).
1010

11-
- [Debian, Ubuntu Linux Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Debian.deb)
12-
- [Red Hat, Fedora, SUSE Linux Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Fedora.rpm)
11+
- [Debian, Ubuntu Linux Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Debian-x64.deb)
12+
- [Red Hat, Fedora, SUSE Linux Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Fedora-x64.rpm)
1313
- [macOS Intel Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-macOS-x64.dmg), [macOS Apple silicon Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-macOS-arm64.dmg)
14-
- [Windows Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Windows.exe)
14+
- [Windows Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Windows-x64.exe)
1515

1616
Additionally, JupyterLab Desktop can be installed on Windows via winget: `winget install jupyterlab`.
1717

src/main/cli.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -537,10 +537,10 @@ export async function createPythonEnvironment(
537537
} else {
538538
const systemPythonPath = getSystemPythonPath();
539539
if (condaBaseEnvExists) {
540-
const createCommand = `python -m venv create ${envPath}`;
540+
const createCommand = `python -m venv ${envPath}`;
541541
await runCommandInEnvironment(baseCondaEnvPath, createCommand, callbacks);
542542
} else if (fs.existsSync(systemPythonPath)) {
543-
execFileSync(systemPythonPath, ['-m', 'venv', 'create', envPath]);
543+
execFileSync(systemPythonPath, ['-m', 'venv', envPath]);
544544
} else {
545545
throw new Error(
546546
'Failed to create Python environment. Python executable not found.'

src/main/pythonenvdialog/pythonenvdialog.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -962,7 +962,7 @@ export class ManagePythonEnvironmentDialog {
962962
createCommandPreview.value = \`conda create -p \$\{getEnvInstallPath()\} \$\{getCondaChannels()\}\ \$\{getPackageList()\}\`;
963963
} else {
964964
const envPath = getEnvInstallPath();
965-
createCommandPreview.value = \`python -m venv create \$\{envPath\}\n\$\{envPath\}\$\{pathSeparator\}${activateRelPath.replace(
965+
createCommandPreview.value = \`python -m venv \$\{envPath\}\n\$\{envPath\}\$\{pathSeparator\}${activateRelPath.replace(
966966
'\\',
967967
'\\\\'
968968
)}\npython -m pip install \$\{getPackageList()\}\`;

0 commit comments

Comments
 (0)