Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): fix first_attempt filter value parsing for Payments #6666

Open
tsdk02 opened this issue Nov 26, 2024 · 0 comments · May be fixed by #6667
Open

fix(analytics): fix first_attempt filter value parsing for Payments #6666

tsdk02 opened this issue Nov 26, 2024 · 0 comments · May be fixed by #6667
Assignees
Labels

Comments

@tsdk02
Copy link
Contributor

tsdk02 commented Nov 26, 2024

  • first_attempt filter takes in true or false as variants.
  • But while it is getting applied in the query, it is being converted into a string:
    'true' or 'false'

This works on latest clickhouse versions, but fails on the older clickhouse versions, with the error:

DB::Exception: Cannot convert string false to type Bool: While processing (first_attempt IN ('false'))

Should fix the issue by converting the way these values are parsed.

@tsdk02 tsdk02 added A-Analytics C-bug Category: Bug labels Nov 26, 2024
@tsdk02 tsdk02 self-assigned this Nov 26, 2024
@tsdk02 tsdk02 linked a pull request Nov 26, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant