Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dynamic fields): dynamic fields for Adyen and Stripe #7015

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(dynamic fields): dynamic fields for Adyen and Stripe #7015

wants to merge 2 commits into from
+13 −47

Conversation

Sweta-Kumari-Sharma
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Modified dynamic fields path of Adyen and Stripe for Klarna. Also klarnaCheckout is renamed to klarnaRedirect in pay later data

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

https://github.com/juspay/hyperswitch-cloud/issues/8052

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sweta-Kumari-Sharma Sweta-Kumari-Sharma requested a review from a team as a code owner January 9, 2025 10:40
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 9, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/adyen/transformers.rs  67% smaller
  crates/hyperswitch_connectors/src/connectors/multisafepay/transformers.rs  46% smaller
  crates/router/src/connector/nuvei/transformers.rs  32% smaller
  crates/hyperswitch_connectors/src/connectors/square/transformers.rs  32% smaller
  crates/hyperswitch_connectors/src/connectors/zen/transformers.rs  32% smaller
  crates/router/src/connector/paypal/transformers.rs  27% smaller
  crates/router/src/connector/stripe/transformers.rs  27% smaller
  crates/api_models/src/payments.rs  13% smaller
  crates/connector_configs/src/transformer.rs  1% smaller
  api-reference-v2/openapi_spec.json  0% smaller
  api-reference/openapi_spec.json  0% smaller
  crates/connector_configs/toml/development.toml Unsupported file format
  crates/hyperswitch_connectors/src/utils.rs  0% smaller
  crates/hyperswitch_domain_models/src/payment_method_data.rs  0% smaller
  crates/router/src/configs/defaults/payment_connector_required_fields.rs  0% smaller
  crates/router/src/connector/klarna.rs  0% smaller
  crates/router/src/connector/klarna/transformers.rs  0% smaller
  crates/router/src/connector/utils.rs  0% smaller

@Sweta-Kumari-Sharma Sweta-Kumari-Sharma linked an issue Jan 9, 2025 that may be closed by this pull request
[REFACTOR] modify dynamic fields path #7014
Open
@Sweta-Kumari-Sharma Sweta-Kumari-Sharma requested a review from a team as a code owner January 15, 2025 03:50
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jan 15, 2025
@Sweta-Kumari-Sharma Sweta-Kumari-Sharma self-assigned this Jan 15, 2025
@Sweta-Kumari-Sharma Sweta-Kumari-Sharma changed the title refactor(dynamic fields): Refactor dynamic fields for Adyen and Stripe refactor(dynamic fields): dynamic fields for Adyen and Stripe Jan 15, 2025
swangi-kumari
swangi-kumari reviewed Jan 15, 2025
View reviewed changes
crates/connector_configs/toml/development.toml
@@ -1771,6 +1771,10 @@ key1="Client Secret"
[klarna]
[[klarna.pay_later]]
payment_method_type = "klarna"
payment_experience = "invoke_sdk_client"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these changes in sandbox.toml and production.toml also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swangi-kumari swangi-kumari swangi-kumari left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@Sweta-Kumari-Sharma Sweta-Kumari-Sharma

Labels
M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] modify dynamic fields path
2 participants
@Sweta-Kumari-Sharma @swangi-kumari