Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getBottomSpace() returns incorrect Y Coordinate in Modal #5

Open
kingmeers opened this issue Sep 28, 2019 · 0 comments
Open

getBottomSpace() returns incorrect Y Coordinate in Modal #5

kingmeers opened this issue Sep 28, 2019 · 0 comments

Comments

@kingmeers
Copy link

Firstly, this is a great component!

Secondly, I understand the reasoning behind adding getBottomSpace() but it doesn't take into consideration whether or not the view is inside a modal, which overlays any tabbed navigation.

I recommend adding a final prop to ensure this is fixed for future issues, let me know if you'd like me to make a PR.

Thank you again!

Samir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant