Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OKTA PKCE支持 #208

Open
yu-th opened this issue Jun 6, 2024 · 0 comments
Open

feat: OKTA PKCE支持 #208

yu-th opened this issue Jun 6, 2024 · 0 comments

Comments

@yu-th
Copy link

yu-th commented Jun 6, 2024

OKTA已经支持PKCE了,建议扩展支持。

另外看代码,AuthAmazonRequest是支持PKCE,但缓存时使用的key是AMAZON:code_verifier:
如果同时有多个请求跳转,后发起的请求会吧前1个的请求缓存的codeVerifier覆盖掉,导致前一个请求无法获取token.
String cacheKey = this.source.getName().concat(":code_verifier:").concat(config.getClientId());
.....
this.authStateCache.cache(cacheKey, codeVerifier, TimeUnit.MINUTES.toMillis(10));
key附加state比clientId更合适吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant