[email protected] - auth token check (#1803)

* auth token check * removing unused function * removing unused function
justeattakeaway · Apr 13, 2022 · 8de42fc · 8de42fc
1 parent 9f68d78
commit 8de42fc
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 37 deletions.
diff --git a/packages/components/pages/f-loyalty/CHANGELOG.md b/packages/components/pages/f-loyalty/CHANGELOG.md
@@ -4,6 +4,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 
+v1.7.3
+------------------------------
+*April 12, 2022*
+
+### Added
+- Check for auth token before setting global user id
+
+
 v1.7.2
 ------------------------------
 *April 05, 2022*

diff --git a/packages/components/pages/f-loyalty/package.json b/packages/components/pages/f-loyalty/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@justeat/f-loyalty",
   "description": "Fozzie Loyalty - provides a way for customers to collect loyalty stamps for restaurants",
-  "version": "1.7.2",
+  "version": "1.7.3",
   "main": "dist/f-loyalty.umd.min.js",
   "maxBundleSize": "101kB",
   "files": [

diff --git a/packages/components/pages/f-loyalty/src/components/Loyalty.vue b/packages/components/pages/f-loyalty/src/components/Loyalty.vue
@@ -123,20 +123,14 @@ export default {
     async mounted () {
         await this.init({
             brazeApiKey: this.brazeApiKey,
-            authToken: this.authToken,
-            logger: this.$log,
-            errorHandler: this.handleErrors
+            authToken: this.authToken
         });
     },
 
     methods: {
         ...mapActions(VUEX_MODULE_NAMESPACE_LOYALTY, {
             init: ACTION_INITIALISE_LOYALTY
-        }),
-
-        handleErrors (error) {
-            this.$emit('onError', error);
-        }
+        })
     }
 };
 </script>

diff --git a/packages/components/pages/f-loyalty/src/store/loyalty.module.js b/packages/components/pages/f-loyalty/src/store/loyalty.module.js
@@ -10,32 +10,10 @@ import {
 /**
  * @function resolveGlobalUserID
  * @param  {string} authToken - auth token.
- * @param logger
- * @param errorHandler
  */
-const resolveGlobalUserID = (authToken, logger, errorHandler) => {
-    try {
-        const tokenData = jwtDecode(authToken);
-        return tokenData?.global_user_id;
-    } catch (error) {
-        logger.error(
-            'Error Decoding JWT token',
-            error,
-            'loyalty',
-            {
-                authToken,
-                exception: error.name,
-                exceptionMessage: error.message,
-                exceptionStackTrace: error.stack,
-                traceId: error.traceId || (error.response && error.response.data.traceId),
-                errorCode: error.errorCode
-            }
-        );
-        // return null and emit error to allow component to emit on error event to
-        // prevent error being handled by general catch all error handler
-        errorHandler(error);
-        return null;
-    }
+const resolveGlobalUserID = authToken => {
+    const tokenData = jwtDecode(authToken);
+    return tokenData?.global_user_id;
 };
 
 export default {
@@ -73,12 +51,14 @@ export default {
             commit(ACTION_SET_GLOBAL_USER_ID, resolveGlobalUserID(authToken, logger, errorHandler));
         },
 
-        [ACTION_INITIALISE_LOYALTY]: ({ commit, dispatch }, {
-            brazeApiKey, authToken, logger, errorHandler
+        [ACTION_INITIALISE_LOYALTY]: ({ commit, dispatch, getters }, {
+            brazeApiKey, authToken
         }) => {
             commit(MUTATION_SET_AUTH_TOKEN, authToken);
             commit(MUTATION_SET_BRAZE_KEY, brazeApiKey);
-            dispatch(ACTION_SET_GLOBAL_USER_ID, { authToken, logger, errorHandler });
+            if (getters.isAuthenticated) {
+                dispatch(ACTION_SET_GLOBAL_USER_ID, { authToken });
+            }
         }
     },