Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pie-monorepo): DSW-000 fix pie test reporters #1748

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Aug 29, 2024

Describe your changes (can list changeset entries if preferable)

  • Updated naming for reporters path for reporters within CI to work correctly.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code

Reviewer checklists (complete before approving)

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview

Reviewer 2 @raoufswe

  • I have reviewed the PIE Storybook/PIE Docs PR preview

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners August 29, 2024 15:25
Copy link

changeset-bot bot commented Aug 29, 2024

⚠️ No Changeset found

Latest commit: cfe502f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the ci label Sep 6, 2024
Copy link
Contributor

@fernandofranca fernandofranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a single comment, though I'm unsure if it's even an issue.

@JoshuaNg2332 JoshuaNg2332 merged commit 5eb6966 into main Sep 9, 2024
56 of 59 checks passed
@JoshuaNg2332 JoshuaNg2332 deleted the DSW-000-fix-pie-test-reporters branch September 9, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants