Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-tag): DSW-2323 add isInteractive prop and rename isDimmed to disabled #1765

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

xander-marjoram
Copy link
Contributor

@xander-marjoram xander-marjoram commented Sep 3, 2024

Describe your changes (can list changeset entries if preferable)

  • [Changed] - Rename isDimmed prop to disabled
  • [Added] - isInteractive prop which renders the tag as a button
  • [Added] - Interactive styling

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
    • I tried this but I don't think it's currently possible with our Playwright/Percy setup. It works locally but the state doesn't make it as far as Percy.
  • I have reviewed the PIE Storybook PR preview
  • I have reviewed the PIE Docs PR preview
  • I have reviewed visual test updates properly
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1 - @jamieomaguire

  • I have reviewed the PIE Storybook PR preview
  • I have reviewed the PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 - @fernandofranca

  • I have reviewed the PIE Storybook PR preview
  • I have reviewed the PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: bf1868d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
pie-docs Patch
@justeattakeaway/pie-tag Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-react17 Patch
wc-react18 Patch
wc-vanilla Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xander-marjoram
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@xander-marjoram xander-marjoram marked this pull request as ready for review September 3, 2024 15:54
@xander-marjoram xander-marjoram requested review from a team as code owners September 3, 2024 15:54
@xander-marjoram xander-marjoram self-assigned this Sep 3, 2024
fernandofranca
fernandofranca previously approved these changes Sep 4, 2024
# Conflicts:
#	packages/components/pie-tag/test/visual/pie-tag.spec.ts
#	yarn.lock
@xander-marjoram xander-marjoram merged commit 61c3729 into main Sep 5, 2024
46 of 51 checks passed
@xander-marjoram xander-marjoram deleted the dsw-2323-interactive-tag branch September 5, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants