-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-tag): DSW-2323 add isInteractive
prop and rename isDimmed
to disabled
#1765
Conversation
🦋 Changeset detectedLatest commit: bf1868d The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/snapit |
Starting a new snapshot build. You can view the logs here. |
@xander-marjoram Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
# Conflicts: # packages/components/pie-tag/test/visual/pie-tag.spec.ts # yarn.lock
Describe your changes (can list changeset entries if preferable)
isDimmed
prop todisabled
isInteractive
prop which renders the tag as a buttonAuthor Checklist (complete before requesting a review)
I have added thorough tests where applicable (unit / component / visual)PIE Storybook
PR previewPIE Docs
PR preview/snapit
functionality to test my changes in a consuming applicationReviewer checklists (complete before approving)
Reviewer 1 - @jamieomaguire
PIE Storybook
PR previewPIE Docs
PR previewReviewer 2 - @fernandofranca
PIE Storybook
PR previewPIE Docs
PR preview