Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-button): DSW-2797 add primary alternative variant #2249

Merged
merged 7 commits into from
Feb 28, 2025

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Feb 26, 2025

Describe your changes (can list changeset entries if preferable)

  • Add the primary-alternative variant.
  • Update the button documentation to align with the new specifications.
  • Clean up unused Markdown files.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @fernandofranca

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2 - @jamieomaguire

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@raoufswe raoufswe requested review from a team as code owners February 26, 2025 14:42
Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: b4c9813

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@justeattakeaway/pie-button Minor
pie-storybook Minor
pie-docs Minor
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-toast Patch
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-toast-provider Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

fernandofranca
fernandofranca previously approved these changes Feb 27, 2025
@fernandofranca
Copy link
Contributor

Should test aperture again?

@raoufswe
Copy link
Member Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@raoufswe Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@raoufswe raoufswe self-assigned this Feb 28, 2025
@raoufswe raoufswe merged commit f87b488 into main Feb 28, 2025
44 of 55 checks passed
@raoufswe raoufswe deleted the dsw-2797-primary-alt-button branch February 28, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants