Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot #6

Open
FoxUSA opened this issue Aug 11, 2014 · 7 comments
Open

Screenshot #6

FoxUSA opened this issue Aug 11, 2014 · 7 comments
Assignees

Comments

@FoxUSA
Copy link

FoxUSA commented Aug 11, 2014

It would be cool if the app would allow you to export a screenshot.

Great idea!

@justincavery
Copy link
Owner

Screenshots would be awesome. At the moment PhantomJS takes a shot of the whole page and doesn't do a great job of pulling through the iframe content consistently enough to make it worthwhile.

I've looked at other options but they have been very browser specific. If you have any suggestions I'm all ears.

@jvmonjo
Copy link

jvmonjo commented Jun 28, 2016

Have you tried https://html2canvas.hertzen.com/ ?
I have, but I haven't managed to take a shot of the web pages, only the frames appear.

@iannerney
Copy link

iannerney commented Dec 14, 2016

@jvmonjo It looks like that's one of the limitations of html2canvas; it doesn't support iframe content.

"The script doesn't render plugin content such as Flash or Java applets. It doesn't render iframe content either." (Reference)

Using a tool like PhantomJS or a third-party service might be the best options available, but I'll keep doing some research. I personally think a screenshot feature would be a very useful for site demos.

@justincavery
Copy link
Owner

@iannerney I had PhantomJS running at one point but it didn't render the screens within the iframe with much accuracy and you also lost your positioning details when you ran it. If you have better luck please feel free so submit a pull request.

@dantheother
Copy link

Chromeless? Headless chrome. Not sure if it would be any better than phantomjs https://github.com/graphcool/chromeless

@justincavery
Copy link
Owner

Great find @dantheother ! I saw someone else tweet about that today but I didn't check it out.

It works MUCH better than PhantomJS so I'll implement this as soon as I can.

@justincavery justincavery self-assigned this Aug 1, 2017
@justincavery
Copy link
Owner

It seems I don't have the time to do this (he says a year on).

I'm happy to accept a pull request for the feature if anyone wants a side side project :)

Repository owner deleted a comment from tobarbaro Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants