New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if Symbol not defined. #31

Open

trusktr opened this issue Apr 27, 2018 · 1 comment

trusktr commented Apr 27, 2018

mixwith.js/src/mixwith.js

Line 181 in d34fe88

if (Symbol && Symbol.hasInstance && !mixin[Symbol.hasInstance]) {

Seems that if Symbol is not defined, there will be an error. Maybe it needs to be a typeof Symbol != 'undefined' check.

The text was updated successfully, but these errors were encountered:

Author

trusktr commented Apr 27, 2018

Oh, and

mixin[Symbol.hasInstance]

will check for Function.prototype[Symbol.hasInstance]. Should that check for an own symbol property instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment