Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when marking activity as completed #41

Open
Fbornemann opened this issue Feb 13, 2023 · 3 comments
Open

Error when marking activity as completed #41

Fbornemann opened this issue Feb 13, 2023 · 3 comments

Comments

@Fbornemann
Copy link

We get an error when a student manually marks an activity starting with a Generico object.
If we place a spec, line shift or any character befor the opening { in the generico command it works fine.

It worked well on our Moodle 3.11 but fails on our 4.1 test setup-

We have something like 150 modules with maybe 20 Generico's each, so manualle fixing it wit a space before the { is not an option...

Skærmbillede 2023-02-13 kl  09 26 02

Skærmbillede 2023-02-13 kl  09 25 32

@justinhunt
Copy link
Owner

I see. That is tricky. I have looked at this on a M4.1 with Boost theme and Atto and can not reproduce it.
The error seems to be related to the template, and not Generico itself.

Can you try with a simple template like warningbox? Does that also fail?

@Fbornemann
Copy link
Author

Fbornemann commented Feb 14, 2023

Hi Justin

Thanks for getting back to us. I just tried with the warningbox. Unfortunately same result.
And still, if I add a space before {Generico....} it works fine.

Setup:
Moodle 4.1 (Build: 20221128)
Theeme Boost
Generico 1.4.18
Generico (Atto) 1.1.1
PHP 7.4.33

Kind regards
Flemming

Skærmbillede 2023-02-14 kl  10 16 51

Skærmbillede 2023-02-14 kl  10 18 11

Skærmbillede 2023-02-14 kl  10 16 34

@justinhunt
Copy link
Owner

I am sorry that I did not come back to this issue. If it is a bug I would be happy to fix it. But I could not reproduce the issue here.
If you are able perhaps you could try to disable all the other filters, and then retest. If it works, then another filter is interfering. If it still fails, can you book a time to speak and we can do a screenshare over zoom. https://calendly.com/poodllsupport/30min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants