Bug (?): When clicking on "Update to version: X.Y", changes to the template are not logged in the configlog report

[danowar2k]

IS: You click on the button, the template content is replaced with the new version, and no one can then see who clicked the button in the first place.

SHOULD: You click on the button, the template content is replaced using Moodle's config API so that changes (and who clicked the button) are logged to the configlog report.

I hope the categorization as a bug is correct.

[danowar2k]

It's strange, though. Looking at the update button code, it seems that Moodle's set_config is used after all. When could this have happened instead of after clicking the button?

EDIT: Oooh. set_config() itself doesn't even call add_to_config_log()...

[justinhunt]

Thanks for following up on that. I wonder why that is the case? I hope it does not affect you poorly

[danowar2k]

Wait...did you change it? Or don't you want to change it?

I still think updating the version should document the changes to the audit log. And to do that I think it would suffice to change:

moodle-filter_generico/classes/presets_control.php

Line 194 in 5f72280

set_config($fieldname . '_' . $templateindex, $fieldvalue, 'filter_generico');

to

$oldValue = get_config($fieldname . '_' . $templateindex, 'filter_generico');
if ($oldValue != $fieldvalue) {
   add_to_config_log($fieldname . '_' . $templateindex, $fieldvalue, $oldValue, 'filter_generico');
}
set_config($fieldname . '_' . $templateindex, $fieldvalue, 'filter_generico');

[danowar2k]

Thanks for following up on that. I wonder why that is the case? I hope it does not affect you poorly

Well, we just found out about a change to a template which we now can't trace back to anyone clicking "update", which can be confusing, for sure.

[justinhunt]

No I did not change it. Sorry I closed it too quick. Yes I guess we could add it to config log. I was not actually aware of that function or log. I will try and look at it soon.