Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Replace monaco editor component with jayvee configuration files #620

Open
5 tasks
TungstnBallon opened this issue Sep 25, 2024 · 0 comments · May be fixed by #621
Open
5 tasks

[FEATURE] Replace monaco editor component with jayvee configuration files #620

TungstnBallon opened this issue Sep 25, 2024 · 0 comments · May be fixed by #621
Labels
enhancement New feature or request

Comments

@TungstnBallon
Copy link
Contributor

User Story

  1. As a {JValue Hub developer}
  2. I want {replace the monaco editor component with languim generated files}
  3. So that {the JValue Hub can import those files}

User Acceptance Criteria

  • The librarymonaco-editor exports the files jayvee.tmLanguage.json and jayvee.configuration.json
  • Removed the react component from the library monaco-editor

Examples

Notes

After https://github.com/jvalue/hub/pull/786 the JValue Hub has its own component for the monaco editor and does not rely on this anymore. However, this component still requires information about jayvee (for syntax highlighting, etc.) and the existing monaco-editor library is a good place to export the required files.

Definitions of Done

  • A PR has been opened and accepted
  • All user acceptance criteria are met
  • All tests are passing
@TungstnBallon TungstnBallon added the enhancement New feature or request label Sep 25, 2024
@TungstnBallon TungstnBallon linked a pull request Oct 4, 2024 that will close this issue
@TungstnBallon TungstnBallon linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant