Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm deletions before doing them. Or add undo. #2

Open
jven opened this issue Jan 3, 2019 · 2 comments
Open

Confirm deletions before doing them. Or add undo. #2

jven opened this issue Jan 3, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@jven
Copy link
Owner

jven commented Jan 3, 2019

Right now deleting a move and deleting a repertoire are irreversible actions so accidentally doing them can lose a lot of data.

Either add an "Are you sure?" warning or make these actions undoable.
@jven
Copy link
Owner Author

jven commented Jan 5, 2019

This was reported once by a user:

"I lost my repertoire by clicking the trash icon and there is no ctrl Z or way to go back :("

@jven jven assigned jven and unassigned jven Jan 6, 2019
@jven
Copy link
Owner Author

jven commented Feb 1, 2019

I added an "Are you sure" dialog for deleting repertoires in abde78c.

Should be able to do the same for deleting nodes from the TreeModel. Maybe the dialog can be shown only if deleting >= 5 moves or so.

@jven jven added the good first issue Good for newcomers label Feb 1, 2019
@aufuss aufuss mentioned this issue Sep 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jven