Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing pipeline part 2 #22

Open
jwbensley opened this issue Feb 23, 2022 · 2 comments
Open

testing pipeline part 2 #22

jwbensley opened this issue Feb 23, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@jwbensley
Copy link
Owner

jwbensley commented Feb 23, 2022 •
edited
Loading

Add test coverage with https://about.codecov.io/

Also, what about GitHub actions?
@jwbensley jwbensley added the enhancement New feature or request label Mar 7, 2022
@jwbensley jwbensley changed the title testing pipeline testing pipeline part 2 Mar 19, 2022
@jwbensley
Copy link
Owner Author

jwbensley commented May 6, 2022 •
edited
Loading

Add AS38336 to whois.py tests - this RIR entry uses ISO-8859-1 encoding.
Add AS8100 to whois.py tests - refers to a private whois server.

@jwbensley jwbensley mentioned this issue May 16, 2022
Merged
jwbensley added a commit that referenced this issue May 16, 2022
@jwbensley
Merge pull request #114 from jwbensley/issue-22
92b9a25 
Fixing issue #22 by adding GIthub action for unit tests
@jwbensley jwbensley mentioned this issue May 17, 2022
Merged
jwbensley added a commit that referenced this issue May 17, 2022
@jwbensley
Working on issue #22 by adding GitHub workers to run Python unit tests
af8e0d4 
Working on issue #22 by adding GitHub workers to run Python unit tests
@jwbensley
Copy link
Owner Author

jwbensley commented Jul 7, 2022 •
edited
Loading

AS8100 has changed their WHOIS output?

======================================================================
FAIL: test_as_lookup (__main__.test_whois)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "dnas/tests/test_whois.py", line 24, in test_as_lookup
    self.assertEqual("", whois.as_lookup(8100))
AssertionError: '' != 'ASN-QUADRANET-GLOBAL'
+ ASN-QUADRANET-GLOBAL

This is now removed from the unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwbensley