From c2ab7aba15e7a2c4c997d3bbdc213ffef36f19d6 Mon Sep 17 00:00:00 2001
From: mattjala <124107509+mattjala@users.noreply.github.com>
Date: Fri, 29 Sep 2023 14:54:23 -0500
Subject: [PATCH] Explicitly fail on unsupported datatype read (#76)

Previously, the read buffer would silently be left uninitialized
as though the read had succeeded.
---
 src/rest_vol_dataset.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/rest_vol_dataset.c b/src/rest_vol_dataset.c
index 6bc0dd49..de977f17 100644
--- a/src/rest_vol_dataset.c
+++ b/src/rest_vol_dataset.c
@@ -4176,6 +4176,9 @@ rv_dataset_read_cb(hid_t mem_type_id, hid_t mem_space_id, hid_t file_space_id, v
 
             memcpy(buf, obj_ref_buf, read_data_size);
         }
+        else {
+            FUNC_GOTO_ERROR(H5E_DATATYPE, H5E_UNSUPPORTED, FAIL, "unsupported datatype");
+        }
     }
 
 done: