From ff97ab7efbb9cff14e74c000ba3ca556ac63f0d9 Mon Sep 17 00:00:00 2001 From: Joakim Antman Date: Sat, 30 Dec 2023 11:00:53 +0200 Subject: [PATCH] Fix requires for x5c_key_finder --- CHANGELOG.md | 1 + lib/jwt/x5c_key_finder.rb | 3 --- spec/x5c_key_finder_spec.rb | 3 --- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e8f679e1..e5d127f8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ - Fix signature has expired error if payload is a string [#555](https://github.com/jwt/ruby-jwt/pull/555) - [@GobinathAL](https://github.com/GobinathAL). - Fix key base equality and spaceship operators [#569](https://github.com/jwt/ruby-jwt/pull/569) - [@magneland](https://github.com/magneland). +- Remove explicit base64 require from x5c_key_finder [#580](https://github.com/jwt/ruby-jwt/pull/580) - [@anakinj](https://github.com/anakinj). - Your contribution here ## [v2.7.1](https://github.com/jwt/ruby-jwt/tree/v2.8.0) (2023-06-09) diff --git a/lib/jwt/x5c_key_finder.rb b/lib/jwt/x5c_key_finder.rb index 57e85bdd..29ae2b79 100644 --- a/lib/jwt/x5c_key_finder.rb +++ b/lib/jwt/x5c_key_finder.rb @@ -1,8 +1,5 @@ # frozen_string_literal: true -require 'base64' -require 'jwt/error' - module JWT # If the x5c header certificate chain can be validated by trusted root # certificates, and none of the certificates are revoked, returns the public diff --git a/spec/x5c_key_finder_spec.rb b/spec/x5c_key_finder_spec.rb index c580c5b3..c5849101 100644 --- a/spec/x5c_key_finder_spec.rb +++ b/spec/x5c_key_finder_spec.rb @@ -1,8 +1,5 @@ # frozen_string_literal: true -require 'spec_helper' -require 'jwt/x5c_key_finder' - describe JWT::X5cKeyFinder do let(:root_key) { OpenSSL::PKey.read(File.read(File.join(CERT_PATH, 'rsa-2048-private.pem'))) } let(:root_dn) { OpenSSL::X509::Name.parse('/DC=org/DC=fake-ca/CN=Fake CA') }