Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go to v1.23.2 #5155

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Bump Go to v1.23.2 #5155

merged 1 commit into from
Oct 30, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 25, 2024 •
edited
Loading

Description

https://groups.google.com/g/golang-announce/c/RQjbRNOcV74/m/N72mEv9ECAAJ
https://go.dev/doc/go1.23

Adapt the internal downloader to upstream chages, as net/http now properly supports context causes.

See: golang/go@a61729b880 ("net/http: return correct error when reading from a canceled request body")
See: golang/go@505000b2d3 ("net/http: simplify HTTP/1 request cancelation")

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123
Bump Go to v1.23.2
77e7fbc 
https://groups.google.com/g/golang-announce/c/RQjbRNOcV74/m/N72mEv9ECAAJ
https://go.dev/doc/go1.23

Adapt the internal downloader to upstream chages, as net/http now
properly supports context causes.

See: golang commit a61729b880 ("net/http: return correct error when reading from a canceled request body")
See: golang commit 505000b2d3 ("net/http: simplify HTTP/1 request cancelation")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review October 29, 2024 07:03
@twz123 twz123 requested review from a team as code owners October 29, 2024 07:03
@twz123 twz123 merged commit 50df531 into k0sproject:main Oct 30, 2024
92 checks passed
@twz123 twz123 deleted the bump-go-1.23 branch October 30, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @jnummelin