Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to identify Raspbian Platform on Linux 5.15.84-v8+ RPiOS Lite 64bit #207

Closed
ztnel opened this issue Jan 8, 2023 · 3 comments
Closed

Comments

@ztnel
Copy link

ztnel commented Jan 8, 2023

According to my understanding RPiOS is just a rebranding of the OS previously called Raspbian. If that's the case I have recently installed a fresh image of RPiOS Lite (64-bit) and this task specifically fails to set thedetected_distribution to Raspbian:

    - name: Set detected_distribution to Raspbian
      set_fact:
        detected_distribution: Raspbian
      when: >
        raspberry_pi|default(false) and
        ( ansible_facts.lsb.id|default("") == "Raspbian" or
          ansible_facts.lsb.description|default("") is match("[Rr]aspbian.*") )

I am bringing this up since Linux 5.15.84-v8+ does not come with cgroup support enabled and the task to enable it is in the Raspbian.yml:

# tasks/prereq/Raspbian.yml
- name: Activating cgroup support
  lineinfile:
    path: /boot/cmdline.txt
    regexp: '^((?!.*\bcgroup_enable=cpuset cgroup_memory=1 cgroup_enable=memory\b).*)$'
    line: '\1 cgroup_enable=cpuset cgroup_memory=1 cgroup_enable=memory'
    backrefs: true
  notify: reboot

I'm not sure how actively this repository is maintained but I don't mind providing a patch for this if it is deemed a bug.

@KI7ODK
Copy link

KI7ODK commented Jan 29, 2023

You are correct. Raspbian has been renamed Raspberry Pi OS by the Raspberry Pi Foundation. I believe the issue you are addressing here is related to pull request #185.

@ztnel
Copy link
Author

ztnel commented Jan 30, 2023

Yea gotcha this seems exactly what we need. I'll try checking out that branch and running it back and report back here.

@dereknola
Copy link
Member

Resolved with #151 instead of #185. Gave priority to oldest PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants