Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update "CLI Installation" section in README.md (#1126) #1127

Merged
merged 2 commits into from
Aug 8, 2024
Merged

docs: update "CLI Installation" section in README.md (#1126) #1127

merged 2 commits into from
Aug 8, 2024

Conversation

ut-wangbo
Copy link
Contributor

Closes #1126

📑 Description

  1. pass the rpm url to the rpm command.
  2. remove the duplicate "-i" option in the 64 bit rpm installation command. 
  3. add the "--allow-untrusted" option to apk installation command.
  4. replace "curl" with "wget" for Alpine Linux.
  5. remove the extra and meaningless "x" at the end of the "APK-based installation (Alpine)" section.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@ut-wangbo ut-wangbo requested review from a team as code owners May 30, 2024 10:23
@ut-wangbo ut-wangbo changed the title docs(readme): update "CLI Installation" section (#1126) docs: update "CLI Installation" section in README.md (#1126) May 30, 2024
@ut-wangbo
Copy link
Contributor Author

@ajayk @AlexsJones @yankay @chenrui333

thx

@AlexsJones
Copy link
Member

but why?

@ut-wangbo
Copy link
Contributor Author

Just try to optimize CLI installation guide. 
Ignore it if it's not necessary.

but why?

Just try to optimize CLI installation guide.  #1126
Ignore it if it's not necessary.

@AlexsJones AlexsJones merged commit b2b8682 into k8sgpt-ai:main Aug 8, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Aug 8, 2024
Merged
ronaldpetty pushed a commit to ronaldpetty/k8sgpt that referenced this pull request Aug 17, 2024
@ut-wangbo @AlexsJones @ronaldpetty
docs: update "CLI Installation" section in README.md (k8sgpt-ai#1126) (…
07582a3 
…k8sgpt-ai#1127)

Signed-off-by: Bo Wang <[email protected]>
Signed-off-by: Alex Jones <[email protected]>
Co-authored-by: Alex Jones <[email protected]>
Signed-off-by: Ronald Petty <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Sep 23, 2024
Merged
AlexsJones added a commit that referenced this pull request Oct 24, 2024
@ut-wangbo @AlexsJones
docs: update "CLI Installation" section in README.md (#1126) (#1127)
fd08097 
Signed-off-by: Bo Wang <[email protected]>
Signed-off-by: Alex Jones <[email protected]>
Co-authored-by: Alex Jones <[email protected]>
Signed-off-by: AlexsJones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: update "CLI Installation" section in README.md
2 participants
@ut-wangbo @AlexsJones