-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enabled auth add support watsonx backend #1190
Conversation
7a4d9f8
to
9e58e5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
and why hide the projectId?
@JuHyung-Son I did not hide it, just remove it from here, as it is my own project id, updated it now using |
I wanted to clarify this change as I don't have the ability to test it. |
@AlexsJones The previous version is right, but the only problem is it request end user to set env vars for apikey and project id, this enhancement is trying to follow the pattern of k8sgpt to set apikey and projectid when adding auth, hope it is OK, thanks. |
Hi @gyliu513. Why not uses |
Signed-off-by: Guangya Liu <[email protected]>
@matthisholleville done, using |
Signed-off-by: Alex Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Guangya Liu <[email protected]> Signed-off-by: Alex Jones <[email protected]> Co-authored-by: Alex Jones <[email protected]> Co-authored-by: Matthis <[email protected]> Signed-off-by: AlexsJones <[email protected]>
Closes #1189
📑 Description
✅ Checks
ℹ Additional Information